[ci] Enable ios_platform_images tests #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter#4899 added integration tests, but I forgot that they were being excluded in CI. This enables them. Fixes flutter/flutter#82208
11 tasks
tarrinneal
approved these changes
Sep 14, 2023
|
Note to self: I actually checked that the test is running in CI this time. |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 15, 2023
flutter/packages@275b76c...bc8c2f2 2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930) 2023-09-14 [email protected] [ios_platform_images] Add extension tests (flutter/packages#4925) 2023-09-14 [email protected] Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929) 2023-09-14 [email protected] [ci] Enable ios_platform_images tests (flutter/packages#4920) 2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922) 2023-09-14 [email protected] Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928) 2023-09-14 [email protected] Manual Roll of Flutter from 4e7a07a to 61b890b (flutter/packages#4919) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@275b76c...bc8c2f2 2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930) 2023-09-14 [email protected] [ios_platform_images] Add extension tests (flutter/packages#4925) 2023-09-14 [email protected] Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929) 2023-09-14 [email protected] [ci] Enable ios_platform_images tests (flutter/packages#4920) 2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922) 2023-09-14 [email protected] Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928) 2023-09-14 [email protected] Manual Roll of Flutter from 4e7a07a to 61b890b (flutter/packages#4919) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4899 added integration tests, but I forgot that they were being excluded in CI. This enables them.
Fixes flutter/flutter#82208